Ad categories should be calculated based upon segment name and top level of segment name #2111
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes brave/brave-browser#3922
Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests && npm run test-security
) onnpm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
Confirm segments in the catalog, i.e.
are created as follows in the database located at
Defaults/ads_service/bundle_state
under the table namead_info_category
contains:Test Case:
brave://rewards
sports-sailing
, checkDefault/ads_service/catalog.json
and you should see the following:bundle_state
and ensure thatsports-sailing
is appearing under both thecategory
andad_info_category
tables, examples:uuid
of the ad that you received matches thesports-sailing
ad_info_uuid
that's under thead_info_category
table viabundle_state
uuid
that you receive matchessports
as we don't have any specific ads forsports-boxing
Reviewer Checklist: